Zdravko Kolev completed this pull request
Show details
No merge conflictsLast checked
Description
Enhanced directives functionality and chartFactory options
Activity feed
chart-integration.directive.ts/projects/igniteui-angular-extras/src/lib/directives/chart-integration/chart-integration.directive.ts HA Hristo Anastasov possible annotate the return type of the method |
chart-integration.directive.ts/projects/igniteui-angular-extras/src/lib/directives/chart-integration/chart-integration.directive.ts HA Hristo Anastasov This method now returns a chart, is it better to annotate its return type |
context-menu.component.ts/projects/igniteui-angular-extras/src/lib/context-menu/context-menu.component.ts HA Hristo Anastasov Is this indexing safe, is it guaranteed that visibleChild always has at least one child |
Zdravko Kolev completed the pull request |
2 |
Zdravko Kolev approved the pull request |
Zdravko Kolev is changed to be a required reviewer |
Zdravko Kolev joined as a reviewer |
Zdravko Kolev left the review |
Zdravko Kolev approved the pull request |
context-menu.component.ts/projects/igniteui-angular-extras/src/lib/context-menu/context-menu.component.ts ZK Zdravko Kolev This is something we will address later on as it requres a small refactoring of the logic to handle memory leaks (already present on production) |
Zdravko Kolev is changed to be a required reviewer |
Zdravko Kolev joined as a reviewer |
Zdravko Kolev removed Hristo Anastasov as a reviewer |
Dobromir Tsvetkov created the pull request |
Reviewers
Required
ZK
Zdravko Kolev
Approved
Optional
No optional reviewers
Tags
No tags